Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wsts 11 #1224

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update to wsts 11 #1224

wants to merge 2 commits into from

Conversation

xoloki
Copy link
Collaborator

@xoloki xoloki commented Jan 15, 2025

Description

Update the wsts dependency to 11.0.0

Closes #1162, closes #1166, and closes #1167

Changes

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@xoloki xoloki marked this pull request as ready for review January 15, 2025 17:42
@xoloki xoloki requested a review from djordon January 15, 2025 17:48
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but let's hold off on merging until we know whether we want to include it or not.

@aldur aldur marked this pull request as draft January 15, 2025 18:21
@cylewitruk
Copy link
Member

Is this still relevant?

@djordon
Copy link
Collaborator

djordon commented Jan 26, 2025

Is this still relevant?

Yes, it is. The updates to WSTS in 0.0.9-rc6 do not include many fixes that have landed on WSTS main.

@xoloki isn't the version here also stale? It includes the listed fixes but it needs to include one more right? As in, don't we need v12.0.0 or something like that? Also, you'll likely see CI fail after merging in main because of cargo-vet, so you'll need to update that here as well.

@djordon
Copy link
Collaborator

djordon commented Jan 26, 2025

Is this still relevant?

Oh maybe not, I missed the PR for v12 🤦🏽!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants