ci: add deposit validation integration tests #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djordon
added
the
transaction library
djordon
force-pushed
the
363-extract-deposit-request-transactions
branch
from
974719c to
d5decfb
Compare
djordon
force-pushed
the
363-integration-tests
branch
from
35dd3e4 to
2724805
Compare
jferrant
reviewed
Jul 30, 2024
jferrant
approved these changes
Jul 30, 2024
Base automatically changed from
363-extract-deposit-request-transactions
to
main
July 30, 2024 20:34
djordon
force-pushed
the
363-integration-tests
branch
from
2724805 to
91a1236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #364 with integration tests and a slight refactor of testing stuff.
Changes
sbtc::testingmodule so that both thesignerand thesbtccrates can use them.sbtc::testingmodule.electrsto the test services run in CI.Testing information
This PR adds the
electrsservice to CI, but uses a different one from the one in devnet. The devnet one builds off of mempool/electrs, but this one uses thegetumbrel/electrscontainer from docker hub, which builds off of romanz/electrs. I'll reconcile them eventually.