Use the fire coordinator to handle missing or malicious signers #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoloki
force-pushed
the
fire-coordinator
branch
from
4616d22 to
d8d19b6
Compare
…ebugging use fire coordinator convenience function to set aggregate key and party poly import fire module; update wsts to latest main which handles BIP-34X map_err can just take a fn doesnt need a closure drop the threshold to 3 to work around test harness bugs when not all signers sign
xoloki
force-pushed
the
fire-coordinator
branch
from
d8d19b6 to
40b1c50
Compare
djordon
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
signerto use theWSTSfire::Coordinatorrather than thefrost::Coordinator. Whereas thefrost::Coordinatorwill wait for all signers to send nonces when starting a signing round, thefire::Coordinatorwill take the firstthresholdof responders and attempt to sign with them.If a signer sends a nonce but does not send a signature share before the configured timeout, or sends a signature share that fails to verify, it is excluded from further signing, and another iteration of the current round is attempted. So at every iteration, we either get a good signature, or we reduce the number of available signers. Thus, we are guaranteed to converge to a good signature or a failure.
The
fire::Coordinatorcan also runDKGwith less than full participation, but we do not anticipate doing so insBTCv1. The timeouts are also configurable, but this PR does not attempt to configure them; rather they are set toNoneas per the existingwsts_state_machine::CoordinatorStateMachine::newfn.Closes: #623
Changes
Testing Information
Existing unit and integration tests should demonstrate sufficiently that this code is working. It was necessary to set the signing threshold to
3/7for some unit test to work around test harness incompatibility with thefire::Coordinator; this was because the test harness assumed that all signers would send signature shares in every round, which is no longer the case.Checklist: