Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle networking bug #907

Merged
merged 26 commits into from
Nov 21, 2024
Merged

fix: handle networking bug #907

merged 26 commits into from
Nov 21, 2024

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Nov 20, 2024

Description

This might address a bug we're seeing on devnet.

I'm not entirely sure this fixes the issue, or if the issue was here at all. But this adds more logging and probably makes things better.

Changes

  • Bump the stream capacity
  • More eagerly send messages along.

Testing Information

Checklist:

  • I have performed a self-review of my code

@djordon djordon self-assigned this Nov 20, 2024
signer/src/transaction_coordinator.rs Outdated Show resolved Hide resolved
signer/src/transaction_coordinator.rs Outdated Show resolved Hide resolved
@cylewitruk cylewitruk self-requested a review November 21, 2024 18:55
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's definitely some cleanup to do here (mostly mine), but given that this branch has been proven in the initial testnet setup, I rather we isolate further changes to iterative changes in future PRs, so approving this 👍

@djordon djordon merged commit dae208e into main Nov 21, 2024
4 checks passed
@djordon djordon deleted the fix-networking-bug branch December 12, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants