Workaround BuildKit Bug in all Docker Composes #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshtonStephens
changed the title
matteojug
reviewed
Nov 27, 2024
matteojug
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #N/A
This is a workaround for the BuildKit bug where buildkit can't figure out that one of the dependencies of a docker container in a compose is actually the base image for the dependent container (or something like that)
Changes
Changes the docker composes to instead use a single Dockerfile with different targets so there's no dependency on a build container.
Testing Information
Tested by running integration tests locally with this. Admittedly I tested the integration tests a lot more than devenv, but it looks good.
Checklist: