Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send sbtc requests context to signers and store sighashs to db #954

Merged
merged 117 commits into from
Nov 25, 2024
Merged

feat: send sbtc requests context to signers and store sighashs to db #954

merged 117 commits into from
Nov 25, 2024

Conversation

Jiloc
Copy link
Collaborator

@Jiloc Jiloc commented Nov 25, 2024

Description

Closes: #794, #913

Changes

  • construct and sends sbtc requests information from the coordinator to the signers
  • signers use the information to reconstruct sighashes of the transactions and save on db their will of signing each tx.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

djordon and others added 30 commits November 14, 2024 10:43
@djordon
WIP
5f013ad
@djordon
Add an outpoint type
b727d5a
@djordon
WIP
f0b03a4
@djordon
WIP
30d1e96
@djordon
Rename the enum
0163613
@djordon
Change the validation output
5727ef6
@djordon
More refactoring
cfce040
@djordon
fake docs
817017b
@djordon
Add documentation
cca72dd
@djordon
This is unnecessary
934169b
@djordon
Fix up more comments
9cb6d79
@djordon
Add todos for more work for validation
3a50480
@Jiloc
add sighashes tables
6defd09
@Jiloc
fix enum name
08242a9
@Jiloc
add bitcoin_withdrawals_outputs table and new queries
2b579c8
@Jiloc
fix tests. add new batch queries
bb9e295
@djordon
Remove locking and just use an ID for
ef2cccc 
keeping track of the signer in the new WanNetwork
@djordon
Add some more comments
4d96ff4
@djordon
Fix up after changes
c414d26
@djordon
Add code to transform the TerminationHandle
3087820 
into a BroadcastStream.
@djordon
Add a new function to the MessageTransfer trait,
d3dcb51 
implement it for the types that implement the trait
@djordon
Add a new function to the Context trait that
1768273 
has a default implementation that combines
all streams that a signer may be interested in
@djordon
Use the new streams in our event loops
8360da6
@djordon
Add in an enum variant
89c08b5
@djordon
Fix up after using the new types
b071223
@djordon
updates after using the new stream
9ef9aeb
@djordon
Temporarily ignore some tests
c96c130
@djordon
Minor changes in the TxSigner
a47ce7c
@djordon
minor test update
23598d6
@djordon
Fix the WSTS bug
7bfa3c6
Jiloc and others added 22 commits November 21, 2024 16:51
@Jiloc
fix typo
aa00ea3
@Jiloc
get_bitcoin_tx_sighash -> will_sign_bitcoin_tx_sighas
e4c5993
@Jiloc
Merge branch '794-save-bitcoin-sighashes-to-db' into feat/validate-bi…
5ad0e3a 
…tcoin-transactions
@Jiloc
update test
4a382c7
@Jiloc
address review comments
a9194e7
@Jiloc
change queries signature to accept slices
d0d00ff
@Jiloc
address review comments
6752482
@Jiloc
Feat/add is unique implementation for request packages (#888)
869b4d3 
* add is_unique logic

* fix lint warning

* add missing import
@Jiloc
Merge branch '798-signers-create-bitcoin-sighashes-2' into 794-save-b…
6529cf2 
…itcoin-sighashes-to-db
@Jiloc
fix test. address comments. make sighash the pk
e99b124
@Jiloc
Merge branch 'main' into 794-save-bitcoin-sighashes-to-db
5842a54
@Jiloc
Merge branch '794-save-bitcoin-sighashes-to-db' into feat/validate-bi…
9fb6d9f 
…tcoin-transactions
@Jiloc
fix test
487c760
@Jiloc
move new tables into new migration file
9528d26
@Jiloc
Merge branch '794-save-bitcoin-sighashes-to-db' into feat/validate-bi…
abdba95 
…tcoin-transactions
@Jiloc
wait for signers acks after sending bitcoin pre request
468153f
@Jiloc
Revert "wait for signers acks after sending bitcoin pre request"
b01cc2c 
This reverts commit 468153f.
@djordon
Fix up the new tables
7af9fd2
@djordon
Merge branch '794-save-bitcoin-sighashes-to-db' into feat/validate-bi…
17e6475 
…tcoin-transactions
@djordon
drop the database at the end
7eb2286
@Jiloc
Merge branch 'main' into feat/validate-bitcoin-transactions
d1eacb6
@Jiloc
Merge branch 'main' into feat/validate-bitcoin-transactions
045d67d
@Jiloc Jiloc requested a review from djordon November 25, 2024 19:48
djordon
djordon reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This picks up from #905

@Jiloc Jiloc merged commit 0942a4a into main Nov 25, 2024
4 checks passed
@djordon djordon mentioned this pull request Nov 25, 2024
Closed
1 task
@Jiloc Jiloc mentioned this pull request Nov 25, 2024
Closed
@Jiloc Jiloc deleted the feat/validate-bitcoin-transactions branch November 25, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djordon djordon djordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Signers store bitcoin sighashes and decisions
2 participants
@Jiloc @djordon