-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change emily config to uri #961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! Semantically it might be a bit confusing because it's an API key and we are shoving it under the username syntax of the URI, but it makes things a lot simpler, so I am happy with it.
Yeah, I figured this was at least more natural than a query param or messing with the url and it's consistent with how we specify other endpoints in the config, so I chose the lesser evil 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should we mark "breaking changes" PRs (in this case, config related one) somehow? So that we remember there's thing we need to do when updating signers
Yeah, I brought that up this morning before I read this in the sbtc channel with my fears of protocol changes, I suggested that we have an additional section in the PR template to annotate additional release considerations -- but we should probably have a label as well so that we can easily check all merged PRs before release. I wonder if we can also get the automated release notes to add a "Breaking Changes" section somehow... |
Description
Changes the Emily endpoint config to a URI in the format
http(s)://[api-key@]<host>:<port>
.Making this change primarily due to the fact that things aren't working well with environment variables and the URI format already supports authentication information.
Changes
.env
files 1-3.Checklist: