Added 'send-many' Function To sBTC Token #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cylewitruk
reviewed
Nov 28, 2024
cylewitruk
reviewed
Nov 28, 2024
cylewitruk
reviewed
Nov 28, 2024
friedger
reviewed
Nov 28, 2024
cylewitruk
reviewed
Nov 29, 2024
setzeus
force-pushed
the
clarity/send-many
branch
from
28941fd to
b4c6e0f
Compare
|
Seeing something odd happening with Clarigen if you have a few minutes to check this out @hstove: Whenever I run 'pnpm test' an additional block is appended to the 'default.simnet-plan.yaml' file, which now breaks the tests that use simnet.block to check the right height (specifically the three tests you currently see failing in this PR). I don't believe 'pnpm test' had this behavior before as these tests were currently passing? Did I cause this locally somehow? |
djordon
approved these changes
Dec 10, 2024
AshtonStephens
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to send multiple(many), specifically up to 200, sBTC transactions at once. This feature is particularly useful for DeFi apps that need to send to many recipients at once. A good example of this is a stacking app that wants to pay stacking rewards in sBTC.
Closes: #934
Changes
Adds one public & one private function to the sbtc-token.clar Clarity contract.
Testing Information
A unit test has been added here.
Checklist: