Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokamoto[Block Proposal]: Signer binary issues signature and broadcasts the block #3930

Closed
kantai opened this issue Sep 15, 2023 · 2 comments

Comments

@kantai
Copy link
Member

kantai commented Sep 15, 2023

After the signer binary has validated a block proposal, it needs to sign the block.

In the Neon milestone, this should be a simple "single signature".

Once the signature has been applied to the block, the signer binary passes the now-finished block back to the stacks-node for broadcasting to the rest of the network.

### Copied from the sBTC breakdown:

Description
Update signers to perform signing rounds Nakamoto block stacker signature hash (the entire block header including miner signature but NOT including stacker signature)

Context
Signers are responsible for validating/signing Nakamoto blocks and returning them to the miner. This ticket enables us to perform the actual signing side of things.

Expected Approach
The message bytes being sent via the signing rounds need to include probably some message type to indicate what type of thing is being signed so that signers can deserialize the contents into a nakamoto block vs btc transaction to inspect. Signers should be able to decide whether they want to sign or not so being able to inspect the contents is required as part of this ticket.

Acceptance Criteria
PR adds the feature to sign blocks
PR adds an integration test for signing a Nakamoto block that includes both a failure case (no quorum), no, and yes result

@kantai kantai added this to the Neon 3.0 milestone Sep 15, 2023
@kantai kantai added argon3.0 and removed neon3.0 labels Nov 3, 2023
@saralab saralab modified the milestones: Neon 3.0, Argon 3.0 Nov 3, 2023
@saralab
Copy link
Contributor

saralab commented Nov 13, 2023

Part 1: stacks-network/sbtc#380
Part 2: stacks-network/sbtc#366

@saralab saralab assigned xoloki and unassigned soju-drinker Jan 5, 2024
@saralab saralab changed the title Nokamoto: Signer binary issues signature and broadcasts the block Nokamoto[Block Proposal]: Signer binary issues signature and broadcasts the block Jan 8, 2024
@saralab saralab moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Jan 11, 2024
@jferrant jferrant self-assigned this Jan 11, 2024
@jferrant jferrant moved this from Status: 📋 Backlog to Status: In Review in Stacks Core Eng Jan 11, 2024
@jferrant jferrant moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jan 11, 2024
@saralab saralab moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Jan 18, 2024
@jferrant jferrant moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Jan 24, 2024
@saralab saralab closed this as completed Jan 24, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

6 participants