Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks node must process successful .signers-voting results #4354

Closed
kantai opened this issue Feb 8, 2024 · 2 comments
Closed

Stacks node must process successful .signers-voting results #4354

kantai opened this issue Feb 8, 2024 · 2 comments

Comments

@kantai
Copy link
Member

kantai commented Feb 8, 2024

The .signers-voting contract emits an event every time a vote is cast, but the stacks-node needs to use this data for getting the actual aggregate public key.

This is the method that currently loads the aggregate public key:

https://github.com/stacks-network/stacks-core/blob/next/stackslib/src/chainstate/nakamoto/mod.rs#L1800

It would need to be updated to invoke something like

(get-approved-aggregate-key reward-cycle) -> (option (buff 33))

Where get-approved-aggregate-key is a read-only method of .signers-voting.

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Feb 8, 2024
@kantai kantai added the argon3.0 label Feb 8, 2024
@saralab saralab moved this from Status: 🆕 New to Status: In Review in Stacks Core Eng Feb 13, 2024
@obycode
Copy link
Contributor

obycode commented Feb 21, 2024

Resolved with #4360.

@obycode obycode closed this as completed Feb 21, 2024
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Feb 21, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants