Process successful .signers-voting results

[obycode]

Description

Adds functionality into the .signers-voting contract to track when an aggregate public key has reached the 70% threshold to be accepted as the key for the next cycle. This key can be queried via the get-approved-aggregate-key read-only function.

Applicable issues

• Builds off of Paging in StackerDB and update to .signers #4323 (will rebase after that is merged)
• Fixes Stacks node must process successful .signers-voting results #4354
• Includes Accept out-of-order votes #4327 to fix [clarity] .signer-voting need to accept out of round votes #4322

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[codecov]

Codecov Report

Attention: 1101 lines in your changes are missing coverage. Please review.

Comparison is base (0b482e3) 60.59% compared to head (d2e6ad8) 54.76%.

Files	Patch %	Lines
...src/chainstate/stacks/boot/signers_voting_tests.rs	35.81%	1002 Missing ⚠️
...kslib/src/chainstate/nakamoto/coordinator/tests.rs	74.77%	56 Missing ⚠️
stackslib/src/chainstate/stacks/boot/mod.rs	46.42%	15 Missing ⚠️
stackslib/src/net/tests/mod.rs	94.26%	7 Missing ⚠️
stackslib/src/chainstate/stacks/db/transactions.rs	66.66%	6 Missing ⚠️
stackslib/src/chainstate/nakamoto/test_signers.rs	96.03%	4 Missing ⚠️
...ckslib/src/chainstate/stacks/boot/signers_tests.rs	84.21%	3 Missing ⚠️
stackslib/src/chainstate/nakamoto/mod.rs	80.00%	2 Missing ⚠️
stackslib/src/clarity_vm/clarity.rs	95.23%	2 Missing ⚠️
...net/stacks-node/src/tests/nakamoto_integrations.rs	99.03%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #4360      +/-   ##
==========================================
- Coverage   60.59%   54.76%   -5.84%     
==========================================
  Files         448      448              
  Lines      321879   323837    +1958     
==========================================
- Hits       195036   177336   -17700     
- Misses     126843   146501   +19658     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[setzeus]

Mainly syntax NITs except for the sequential (and ...) near the end of the vote function.

Assuming these are fixed & includes everything @jferrant needs to continue tests it should be GTM.

[jcnelson]

LGTM; just make sure CI passes after resolving any merge conflicts. Thanks!

[obycode]

Merged next and resolved conflicts in 055fad3.

[obycode]

Merged again and waiting for test results.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.