Add stack-aggregation-increase command #4652
Conversation
Adding the `StackAggregationIncreaseCommand` is currently causing the tests to fail. To investigate: - this may be a PoX-4 bug - this may be a command implementation issue
|
@friedger @moodmosaic @setzeus adding the In case the command is correct, there may be some PoX-4 unexpected behavior. Thank you in advance! |
| * Constraints for running this command include: | ||
| * - The Operator must have locked STX on behalf of at least one stacker. | ||
| * - The PoX address must have partial committed STX. | ||
| * - The Reward Cycle Index must be positive. |
There was a problem hiding this comment.
The reward cycle index must be one of the returned indexes by the first aggregation commit tx for the pox address.
There was a problem hiding this comment.
Yes, I pick it from the list at the generator level, here
| @@ -112,6 +112,7 @@ export class StackAggregationCommitAuthCommand implements PoxCommand { | |||
|
|
|||
| const operatorWallet = model.wallets.get(this.operator.stxAddress)!; | |||
| operatorWallet.amountToCommit -= committedAmount; | |||
| operatorWallet.committedRewCycleIndexes.push(model.nextRewardSetIndex); | |||
There was a problem hiding this comment.
If the wallet is using more than one pox address the index storage should be a map of pox addresses to a list of indexes.
|
LGTM; should be ready to merge once we address @friedger's comments. |
|
Merging into |
moodmosaic
merged commit ee51196
into
feat/pox-4-stateful-property-testing
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds the
stack-aggregation-increasecommand to the stateful property testing environment. It is part of #4548 and targetsfeat/pox-4-stateful-property-testing(#4550).