chore(clarity): Remove unused imports and enable warning #5660
+222
−447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
approved these changes
Jan 22, 2025
Merged
via the queue into
stacks-network:develop
with commit Jan 22, 2025
9cacb22
169 of 180 checks passed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused imports in clarity, and remove the line
#![allow(unused_macros)]to enable unused import warnings for this crateAdditional info (benefits, drawbacks, caveats)
I've left
#![allow(unused_macros)]on for src/vm/analysis/tests. This module is compiled with the condition#[cfg(any(test, feature = "testing"))], and it's thetestingfeature flag that causes the issue here, since most of the code is inside unit tests marked with#[test]. I don't want to mess with this now and risk breaking something that uses Clarity'stestingfeatureI've tested that clarity still builds with all feature flags found in Cargo.toml