feat: record validation and end-to-end response time in signer metrics #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbencin
previously approved these changes
Jan 10, 2025
obycode
reviewed
Jan 10, 2025
obycode
previously approved these changes
Jan 10, 2025
jcnelson
reviewed
Jan 15, 2025
jcnelson
requested changes
Jan 15, 2025
obycode
previously approved these changes
Jan 16, 2025
to reduce the amount of `cfg` macros needed
obycode
reviewed
Jan 16, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two metrics:
stacks_signer_block_response_latencies_histogram: this measures the "end-to-end" time that the signer takes to respond to a block proposal. The block's timestamp is used as the "start time", so this isn't a totally fair end-to-end measurement, but it's directionally accurate.stacks_signer_block_validation_latencies_histogram: thevalidation_time_msreported by the node when validating a block proposal