Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased mining timeout in mock_mining and partial_tenure_fork integration tests #5670

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Jan 8, 2025

Description

This patch increases mining timeout for 2 integration tests for allowing the CI to not fail on them.

The tests are:

tests::nakamoto_integrations::mock_mining
tests::signer::v0::partial_tenure_fork

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris requested a review from a team as a code owner January 8, 2025 15:07
@aldur aldur requested review from obycode, jbencin and hstove January 8, 2025 16:06
@jbencin
Copy link
Contributor

jbencin commented Jan 8, 2025

Can you provide some info in the description on how this was tested or why the longer timeout is necessary? Like how many times was this tested and the failure rates using the different timeout, or what specifically was taking longer than 1-2 minutes that made the previous timeouts inadequate?

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad it was that simple!

@rdeioris
Copy link
Contributor Author

rdeioris commented Jan 8, 2025

@jbencin in all of the runner errrors i was able to get related to the two tests (unofrtunately the runner logs in the base issue are no more available as they got recycled) the error was always "Timed out waiting for follower to catch up to the miner".

This is effectively the time the test thread waits for the synchronization of a follower (spawned in a new thread) til the chain tip.

On my local machine this time is extremely variable while running tests (between 40 and 60 seconds). If you think it is worthy i can log the time required by a github worflow node to have a better idea on the true timings

@hstove hstove added this pull request to the merge queue Jan 9, 2025
Merged via the queue into develop with commit cbc9406 Jan 9, 2025
13 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants