chore: add allow(clippy::needless_as_bytes) for some Clarity codecs #5678
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
force-pushed
the
clippy/warn-asbytes
branch
from
c3e17d0 to
430385e
Compare
kantai
force-pushed
the
clippy/warn-asbytes
branch
from
7dabc74 to
5b96659
Compare
jferrant
approved these changes
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds
allowdecorators to some message codec implementations. Theas_bytes()invocations are indeed needless, but I think the verbosity is preferable in the codec (so that its very clear to readers that we're concerned with byte length, rather than character length).This should fix two checks in CI.