feat: implement dry-run mode for signer #5680
Open
+196
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
force-pushed
the
feat/dry-run-signer
branch
from
8fa4d11 to
b5b27a3
Compare
kantai
force-pushed
the
feat/dry-run-signer
branch
from
b5b27a3 to
d4ad769
Compare
jferrant
previously approved these changes
Jan 13, 2025
hstove
previously approved these changes
Jan 16, 2025
hstove
requested changes
Jan 21, 2025
CHANGELOG.md
Outdated
| @@ -15,7 +24,7 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE | |||
| ### Changed | |||
|
|
|||
| - The RPC endpoint `/v3/block_proposal` no longer will evaluate block proposals more than `block_proposal_max_age_secs` old | |||
| - When a transaction is dropped due to replace-by-fee, the `/drop_mempool_tx` event observer payload now includes `new_txid`, which is the transaction that replaced this dropped transaction. When a transaction is dropped for other reasons, `new_txid` is `null`. [#5381](https://github.com/stacks-network/stacks-core/pull/5381) | |||
| - When a transaction is dropped due to replauce-by-fee, the `/drop_mempool_tx` event observer payload now includes `new_txid`, which is the transaction that replaced this dropped transaction. When a transaction is dropped for other reasons, `new_txid` is `null`. [#5381](https://github.com/stacks-network/stacks-core/pull/5381) | |||
There was a problem hiding this comment.
Hi are you trying to make me look bad by adding a typo to my changelog entry?
obycode
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a dry-run mode for the signer (see #5668)