-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Apply Clippy format string lints #5723
Merged
jbencin
merged 10 commits into
stacks-network:develop
from
jbencin:chore/clippy-format-strings
Jan 22, 2025
Merged
chore: Apply Clippy format string lints #5723
jbencin
merged 10 commits into
stacks-network:develop
from
jbencin:chore/clippy-format-strings
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
previously approved these changes
Jan 17, 2025
jbencin
force-pushed
the
chore/clippy-format-strings
branch
from
January 17, 2025 19:33
c504bc0
to
856542d
Compare
obycode
reviewed
Jan 18, 2025
obycode
previously approved these changes
Jan 21, 2025
jcnelson
previously approved these changes
Jan 22, 2025
jferrant
approved these changes
Jan 22, 2025
obycode
approved these changes
Jan 22, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
chore: Apply Clippy format string lints
Merged
via the queue into
stacks-network:develop
with commit Jan 22, 2025
a077937
180 of 186 checks passed
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply Clippy lints related to format strings. Specifically, the following:
to_string_in_format_args
useless_format
format_in_format_args
Also there's a few other random, non-Clippy fixes in here that I didn't want to make a separate PR for