Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply Clippy format string lints #5723

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jan 17, 2025

Description

Apply Clippy lints related to format strings. Specifically, the following:

  • to_string_in_format_args
  • useless_format
  • format_in_format_args

Also there's a few other random, non-Clippy fixes in here that I didn't want to make a separate PR for

@jbencin jbencin requested a review from a team as a code owner January 17, 2025 18:47
jferrant
jferrant previously approved these changes Jan 17, 2025
@jbencin jbencin force-pushed the chore/clippy-format-strings branch from c504bc0 to 856542d Compare January 17, 2025 19:33
@jbencin jbencin requested a review from obycode January 19, 2025 19:01
obycode
obycode previously approved these changes Jan 21, 2025
jcnelson
jcnelson previously approved these changes Jan 22, 2025
@jbencin jbencin dismissed stale reviews from jcnelson and obycode via 02841df January 22, 2025 15:43
@jbencin jbencin requested review from obycode and jcnelson January 22, 2025 15:43
@jbencin jbencin added this pull request to the merge queue Jan 22, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2025
chore: Apply Clippy format string lints
Merged via the queue into stacks-network:develop with commit a077937 Jan 22, 2025
180 of 186 checks passed
@jbencin jbencin deleted the chore/clippy-format-strings branch January 22, 2025 19:56
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants