Test flake: global_acceptance_depends_on_block_announcement #5733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix test flakiness in
signer::v0::global_acceptance_depends_on_block_announcement
.I believe the issue was that poor timing in the CI could cause the checks at the end to work like this:
info_before
is checked with stacks height N.next_block_and()
issues a bitcoin block B+1B+1
, the signers upload stacks blockN+1
(because the test directives are all reset). This happens without a new proposal being sent out.next_block_and()
finishes successfully becauseN+1
advances the stacks tipinfo_after
is set atN+1
, which has consensus hash for Bitcoin Block B (not B+1)This test corrects this by making step 2 wait for a new stacks block to be produced in
B+1
's tenure.