-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional assets that are available. #6
Comments
@gadomski seems like this can be closed? |
I don't see any additional assets here: cop-dem/src/stactools/cop_dem/stac.py Lines 77 to 96 in f7e2207
None in |
If you look at the image above the additional assets exist on the AWS bucket. The current code ignores their existence. The fact that it's not in the
|
Thanks @wildintellect -- I was just asking because this issue was referenced from a merge PR, but I didn't know (or look to see) if that PR had resolved the issue. |
@philvarner Ah the comment in the PR specifically was about if this needed to be solved for that PR. The decision was no, to put off adding the Assets to a later time. |
Hello everyone. Do you currently plan to include the above mentioned aux files as assets in |
@muelj12 no one is actively working on this. Can you explain the need for some of the other files to help us prioritize their inclusion? |
@wildintellect I can provide some details. We work on generating a Sentinel-1 Normalized Radar Backscatter (https://sentinels.copernicus.eu/web/sentinel/sentinel-1-ard-normalised-radar-backscatter-nrb-product) product. We make use of the Copernicus 30m DEM for the terrain correction and as part of the output layers a water body mask is being generated (e.g., see a prototype implementation from ESA https://github.com/SAR-ARD/S1_NRB). We request the DEM tiles from our STAC API and would like to do so for the auxiliary layers. We plan to conduct an implementation using stactools-cop-dem, but we have a slightly different structure of the files (our basis is the original folder structure and file naming as presented in the screenshot above. The Copernicus DEM data is now available for direct download (https://sentinels.copernicus.eu/web/sentinel/-/copernicus-dem-new-direct-data-download-access). In comparison to the data on AWS. The original structure of files has a dedicated sub-folder for the DEM and "COG" is not included in the file name. I hope we do not need to have separate packages for Copernicus DEM data hosted on AWS and hosted elsewhere with the original folder structure. |
@jonas-eberle I see what you mean about the slightly different structure of the folders in the It does seem like the masks in the AUXFiles are important for use cases so I'll see if I can work on it next week, but if someone wants to collaborate on that I'm open to it. |
@wildintellect We have seen that there is already a COP-DEM STAC collection on AWS, where the AUXFiles are integrated as additional assets. One could possibly use their tags as a guide (e.g.: aws s3 ls --no-sign-request s3://copernicus-dem-30m-stac/). |
@gadomski @philvarner can you assign this ticket to me 🙇 |
Question: should these additional asset be optional arguments to the cli/functions for create_item? |
I don't think there needs to be an option. If someone doesn't want them for whatever reason, they can remove them. |
Is your feature request related to a problem? Please describe.
The original package only includes the core Data asset but not any of the other auxiliary files which are available.
This includes files that some might find useful: Quicklook shaded relief for visualization, mask layers for water, xml metadata, etc...
Describe the solution you'd like
Add the additional assets that are available on the same AWS open data bucket.
Describe alternatives you've considered
Since the core DEM is what most users want, this can be skipped/optional for many people.
Additional context
From the latest product handbook (June 2022)
The text was updated successfully, but these errors were encountered: