Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the item id #9

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Change the item id #9

merged 3 commits into from
Apr 3, 2023

Conversation

gadomski
Copy link
Contributor

@gadomski gadomski commented Mar 15, 2023 •
edited
Loading

Related Issue(s):

Description:
This is the item id that's present in Azure blob storage for the Planetary Computer. Also includes a script to create the example files.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski requested a review from pjhartzell March 15, 2023 20:22
@gadomski gadomski self-assigned this Mar 15, 2023
pjhartzell
pjhartzell reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id change seems very Planetary Computer centric. Are any other orgs relying on this package?

@gadomski
Copy link
Contributor Author

The id change seems very Planetary Computer centric. Are any other orgs relying on this package?

It's a good question, and a hard one to answer. Two options, as I see it:

  • Release a version before changing this ID, just in case
  • Provide a boolean switch to pick which type of ID you want w/ your item, keeping the current ID as default

@pjhartzell
Copy link
Contributor

+1 on a release prior to the change. The boolean switch can be added later if needed.

@gadomski
Copy link
Contributor Author

Released v0.4.0 to bookmark before the ID change: https://pypi.org/project/stactools-sentinel3/0.4.0/.

@gadomski gadomski requested a review from pjhartzell March 31, 2023 16:11
@gadomski gadomski merged commit 5d27c84 into main Apr 3, 2023
@gadomski gadomski deleted the issues/7-item-id branch April 3, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix item id
2 participants
@gadomski @pjhartzell