[STA-3724] automerge filters: fix early return in conventional commit filter #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meorphis
force-pushed
the
emorphis-release-please-fix-conv-commit-filter
branch
from
fe81a1d to
ad7d307
Compare
|
Thanks, the existing tests didn't catch this? |
dgellow
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were always returning inside the
for (const commit of pullRequest.conventionalCommits)loop which meant that we would only ever look at the first commit (in both the match-all and the match-at-least-one case). The default return statements need to happen outside of the loop.