Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Update tronador docs with submodule mkdocs SA 5303 #20

Merged
merged 17 commits into from
May 27, 2024
Merged

[Task] Update tronador docs with submodule mkdocs SA 5303 #20

merged 17 commits into from
May 27, 2024

Conversation

RSAK56
Copy link
Contributor

@RSAK56 RSAK56 commented May 24, 2024 •
edited
Loading

Description

  1. Updated tronador docs with mkdocs theme common submodule
  2. Shifted vocabulary to vale and removed vocabulary submodule
    Fixes # (issue)
    UI/UX

Type of change

Enhancement

  • Bug fix (non-breaking change which fixes an issue)
  • UI/UX modification
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RSAK56 RSAK56 added the enhancement New feature or request label May 24, 2024
@RSAK56 RSAK56 self-assigned this May 24, 2024
RSAK56 added 3 commits May 25, 2024 01:32
@RSAK56
Updated mkdocs yml
d161484
@RSAK56
Merge branch 'task/update-tronador-docs-with-submodule-mkdocs-sa-5303…
3ad5b9b 
…' of github.com:stakater/tronador-docs into task/update-tronador-docs-with-submodule-mkdocs-sa-5303
@RSAK56
Updated mkdocs yml theme override
0b04823
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

@karl-johan-grahn Image is available for testing. docker pull ghcr.io/stakater/tronador-docs:v0.0.17

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-ae2c0638

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-1bd48537

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-ae2c0638

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-39e4437e

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-ae2c0638

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-e3d4874f

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-9bc006a3

karl-johan-grahn
karl-johan-grahn requested changes May 26, 2024
View reviewed changes
Copy link
Contributor

@karl-johan-grahn karl-johan-grahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add generic logos, they should be added through the common theme

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-a7d1447b

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-1d11d234

@RSAK56
Copy link
Contributor Author

RSAK56 commented May 27, 2024

Don't add generic logos, they should be added through the common theme

Updated the footer logos to theme common, logo's apart from them will need to be updated when provided by design teams. Each doc will have a one separate logo in the header. So keeping the header ones in the override.

@RSAK56 RSAK56 requested a review from karl-johan-grahn May 27, 2024 09:18
@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-4ace80db

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-a27dddcf

karl-johan-grahn
karl-johan-grahn requested changes May 27, 2024
View reviewed changes
content/config_file.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-4b574cfe

@github-actions GitHub Actions
Copy link

@RSAK56 Image is available for testing. docker pull ghcr.io/stakater/stakater/tronador-docs:SNAPSHOT-PR-20-8bd9721f

@RSAK56 RSAK56 requested a review from karl-johan-grahn May 27, 2024 16:27
@karl-johan-grahn karl-johan-grahn merged commit 3b55ace into main May 27, 2024
5 checks passed
@karl-johan-grahn karl-johan-grahn deleted the task/update-tronador-docs-with-submodule-mkdocs-sa-5303 branch May 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-johan-grahn karl-johan-grahn karl-johan-grahn approved these changes

@tanalam2411 tanalam2411 Awaiting requested review from tanalam2411

@ufateh ufateh Awaiting requested review from ufateh

Assignees

@RSAK56 RSAK56

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RSAK56 @karl-johan-grahn