-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH action for releasing with BigWigsMods/packager #68
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Package and release | ||
|
||
# we need to let GitHub know _when_ we want to release, typically only when we create a new tag. | ||
# this will target only tags | ||
on: | ||
push: | ||
tags: | ||
- '**' | ||
|
||
jobs: | ||
release: | ||
runs-on: ubuntu-latest | ||
|
||
# specify the environment variables used by the packager, matching the secrets from the project on GitHub | ||
env: | ||
GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }} # "GITHUB_TOKEN" is a secret always provided to the workflow | ||
|
||
|
||
# "steps" holds a list of all the steps needed to package and release our AddOn | ||
steps: | ||
|
||
# we first have to clone the AddOn project, this is a required step | ||
- name: Clone project | ||
uses: actions/checkout@v3 | ||
|
||
|
||
# once cloned, we just run the GitHub Action for the packager project | ||
- name: Package and release | ||
uses: BigWigsMods/packager@v2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a step here to remove the stuff from the repo that we don't want to get packaged up with the mod? Those files would be:
.github/
and.luacheckrc
- not that they are sensitive data, but they're not relevant to the playerSomething like:
It looks like this would also be achievable by adding a
.pkgmeta
file to the repo per https://github.com/BigWigsMods/packager/wiki/Preparing-the-PackageMeta-File#changing-the-package-nameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look here: https://github.com/MyGamesDevelopmentAcc/sArena/releases/tag/testrelease_1
Those files do not land in the release already.
For curse to work it would require just adding the curse key by @stako .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Don't hesitate to share that kind of context (link to test release) in the PR description :)