This repository has been archived by the owner on Mar 8, 2022. It is now read-only.
submit Om Next solution #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the submission, and so sorry to take so long to review it. It's almost perfect. Here's a problem I noticed: the list of items should never do a sudden "jump" like this:
Here's how any other submission behaves:
|
|
OK, thanks for the feedback! I'd assumed that the five rows should be populated if possible, hence the jump on the initial load when the UI figures out that the first request is only 3 from the end. I'll add a commit to fix. |
The first request (from the specifications) happens to be the third jedi from the end of the list, so the final jedi appeared in the third row. In the previous implementation, that row was auto-scrolled to the bottom and the table was filled at the top. This commit removes that behaviour after staltz's comments in staltz#58.
|
Hi again - I've committed a change to stop the auto-scrolling on initial load. |
|
hi @staltz - might you get a chance to merge this? i'd like to refer to it in some docs and would prefer to link to your master branch - thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution uses clojurescript and om next.