Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stan CSV parsing for save warmups #1131

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

bdeonovic
Copy link
Contributor

Summary:

Currently there is bug in parsing stan CSV output files to turn into rstanfit object using read_stan_csv which results in NA value for the field save_warmup resulting in the error

r$>  rstan::read_stan_csv(cmdstan_m_robit_3pl$output_files())
Error in if (max(save_warmup) == 0L) { : 
  missing value where TRUE/FALSE needed
In addition: Warning message:
In parse_stancsv_comments(comments) : NAs introduced by coercion

Intended Effect:

How to Verify:

using package versions: cmdstanr_0.8.1 rstan_2.32.6

Side Effects:

Documentation:

Reviewer Suggestions:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bdeonovic
Copy link
Contributor Author

bump?

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants