Remove custom C++ functions #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look into the test failure tomorrow; it seems to be related to the following exception: Exception: csr_matrix_times_vector: u/z (34) and v (35) must match in size
(in '/model/eta_add_Zb.stan' at line 2; included from 'model_continuous' at line 150) |
|
@bgoodri Before I spend time to fix the failed examples/tests (which refer to the checks in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #514 and #555, this PR removes all custom C++ functions and uses the replacement from Stan/Math. It also fixes building
rstanarmwith Stan v2.28.2, which requires a very minor patch for Math.