-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change rule no-unused-vars to include args option #136
Conversation
Note: The one failing test is |
Sorry my mistake, I ran the tests wrong. This change does impact the ecosystem:
Ecosystem impact:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see this. Would be a major version
Agreed @DiegoRBaquero, I would also like to see this. I was waiting until it was "approved" and then I could start working through helping the effected projects. |
You can read why this was not enabled in the past: standard/standard#419 Basically, because of how So, if we enable this, then folks would need to be really careful not to accidentally remove the unused arguments at the suggestion of |
Moving discussion to standard/standard#419 |
Currently
no-unused-vars
uses the option"args": "none"
. This proposed change removes the args option (relying on the defaultafter-used
).Before the change:
After the change:
References: