Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to redact model outputs #3301

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Add support to redact model outputs #3301

merged 5 commits into from
Feb 3, 2025

Conversation

MiguelAFH
Copy link
Collaborator

As part of MedHELM, we need the ability to redact not only the requests, but also the generated responses. This is to prevent PIH data from real patients.

@MiguelAFH MiguelAFH requested a review from yifanmai January 30, 2025 17:46
@yifanmai
Copy link
Collaborator

Overall it looks good to me. Couple of notes:

  1. Could you run the linter? Install the [dev] extras (or you can install the linter directly using pip install black==24.3.0 flake8==5.0.4 mypy==1.5.1) and then run ./pre-commit.sh, and then make the requested fixes.
  2. I would prefer to replace tokens with the empty array [] in case the length of the array leaks some information.

@MiguelAFH MiguelAFH merged commit 714a97d into main Feb 3, 2025
8 checks passed
@MiguelAFH MiguelAFH deleted the redact-output branch February 3, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants