Report whole packet bytes in ConnRecord #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HKalbasi
force-pushed
the
fix-nb-bytes
branch
from
b1a943d to
9ea22fd
Compare
|
This LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in finding out the percentage of traffic bytes used by each reported connection. Currently,
ConnRecordreports only payload bytes, which excludes malformed packets and ethernet/ip headers. I added a new fieldnb_pkt_bytestoFlowin theConnRecordfor this propose and renamed the oldnb_bytestonb_payload_bytesto reduce confusion.