Add support for DPDK 24.11 #92
Conversation
* run ci for toolchain 1.81.0 * run ci for toolchain 1.84.0 * cache dpdk build * check dpdk cache * fix dpdk cache * run ci * fix * fix ci
| @@ -66,7 +69,7 @@ fn main() { | |||
| .stdout; | |||
|
|
|||
| if ldflags_bytes.is_empty() { | |||
| println!("Could not get DPDK's LDFLAGS. Are DPDK_PATH, LD_LIBRARY_PATH set correctly?"); | |||
| println!("Could not get DPDK's LDFLAGS. Is LD_LIBRARY_PATH set correctly?"); | |||
| uses: actions/checkout@v3 | ||
|
|
There was a problem hiding this comment.
not a big deal, but it is nice to have conceptually separate changes in separate PRs (formatting or toolchain changes like this vs. the DPDK update)
|
Thanks for submitting! Can you name in the PR description how y'all have tested this so far? |
| @@ -89,7 +89,7 @@ impl fmt::Debug for Mempool { | |||
|
|
|||
| /// Rounds `n` up to the nearest multiple of `s` | |||
| fn round_up(n: u32, s: u32) -> u32 { | |||
| ((n + s - 1) / s) * s | |||
| (n.div_ceil(s)) * s | |||
There was a problem hiding this comment.
can you revert this and submit in a separate PR? unless there is some reason why it's tightly coupled to the DPDK change that I am missing
| @@ -24,7 +24,7 @@ pub struct Ipv6<'a> { | |||
| mbuf: &'a Mbuf, | |||
| } | |||
|
|
|||
| impl<'a> Ipv6<'a> { | |||
| impl Ipv6<'_> { | |||
There was a problem hiding this comment.
similarly - the lifetime syntax changes would ideally be reverted and submitted in a separate PR
| @@ -33,6 +33,132 @@ impl rte_ipv4_hdr { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(not(dpdk_ge_2411))] | |||
There was a problem hiding this comment.
@tbarbette @thegwan these refactors to account for the interface changes LGTM, but checking if either of you have any concerns from working on the original DPDK layer?
This PR adds support for DPDK 24.11 while preserving the support for previous DPDK versions.
Changes included in this PR: