Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom text key to WeaviateRM - resolve issue #359 #360

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

CShorten
Copy link
Collaborator

@CShorten CShorten commented Feb 9, 2024

Lets you specify which text key to return from a call to dspy.Retrieve

This does not incur a breaking change thanks to the Optional typing and default argument value.

This will resolve #359.

@insop
Copy link
Contributor

insop commented Feb 16, 2024

With a cursory check, it looks great!

Hi @CShorten,

You could take this suggestion to a separate PR.
I think it'd be great if you could add WeaviateRM description to this markdown docs/retrieval_models_client.md.
This is a PR that adds description for other RM to this document: #400.

@okhat okhat merged commit c02642d into stanfordnlp:main Feb 17, 2024
1 check passed
@okhat
Copy link
Collaborator

okhat commented Feb 17, 2024

Thank you @CShorten and @insop ! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weaviate RM should NOT assume that "content" contains the text of the passage
3 participants