Create Google LM #398
Merged
Create Google LM #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insop
reviewed
Feb 16, 2024
dsp/modules/google.py
Outdated
| Additional arguments to pass to the API provider. | ||
| """ | ||
| super().__init__(model) | ||
| self.google = genai.configure(api_key="") |
There was a problem hiding this comment.
could it be this? setting api_key instead of ""
self.google = genai.configure(api_key=api_key)
There was a problem hiding this comment.
Ah great catch! Sorry about that! Updating!
dsp/modules/google.py
Outdated
| self.provider = "google" | ||
| self.kwargs = { | ||
| "model_name": model, | ||
| "temperature": 0.0, |
There was a problem hiding this comment.
temperature and other configuration might be convenient to update through kwargs
How about something like this?
"temperature": 0.0 if "temperature" not in kwargs else kwargs["temperature"],
There was a problem hiding this comment.
Awesome, good call!
dsp/modules/google.py
Outdated
| self, | ||
| model: str = "gemini-pro-1.0", | ||
| api_key: Optional[str] = None, | ||
| stop_sequences: list[str] = [], |
There was a problem hiding this comment.
would stop_sequences be used?
There was a problem hiding this comment.
Ah another great catch!
|
Thank you so much @CShorten! It'd be great if you could update this markdown doc as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the Cohere LM template. It doesn't look like you can sample multiple generations in one call to the API (linked the Google API docs I'm following in the code). Outside of that, I think it is a pretty standard implementation in sync with the other LMs.
Comment:
historyis stored as internal state to the LMs as alist[dict[str, Any]]. I would like to explore adding functionality around inspect_history next.