Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): ReAct doesn't use instructions from the given Signature #992

Merged
merged 2 commits into from
May 11, 2024
Merged

fix(react): ReAct doesn't use instructions from the given Signature #992

merged 2 commits into from
May 11, 2024

Conversation

xyloid
Copy link
Contributor

@xyloid xyloid commented May 8, 2024

When I use ReAct with Signature, I find that the instructions field in the given signature is ignored by the ReAct class, this behavior is not consistent with Predict. This fix provides a workaround for the issue.

@arnavsinghvi11 arnavsinghvi11 merged commit 61fd5cc into stanfordnlp:main May 11, 2024
4 checks passed
@arnavsinghvi11
Copy link
Collaborator

Thanks for the PR @xyloid ! this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xyloid @arnavsinghvi11