Implement .lines() method on various string slices #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to this issue, I have implemented a .lines() method on Utf16Str and Utf32Str as well as a lines_lossy() method on U16Str and U32Str.
There may be other string types in this crate where this could make sense, but these were the most pressing for my use-case. I'm happy to implement any others that would be necessary before merging.
There may also be a use for implementing DoubleEndedIterator here since the standard library implementation does, but I think most use-cases will be iterating through the lines in sequentially forward order.