Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fixes in "Starknet state" #555

Merged
merged 14 commits into from
Jun 16, 2023
Merged

fix: minor fixes in "Starknet state" #555

merged 14 commits into from
Jun 16, 2023

Conversation

LandauRaz
Copy link
Collaborator

@LandauRaz LandauRaz commented Jun 14, 2023

Description of the Changes

Minor fixes in "Starknet state".

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-555/documentation/architecture_and_concepts/State/starknet-state/

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

JameStark and others added 8 commits June 13, 2023 10:52
* chore(release): 0.1.158

* Update wording on AA Deploying accounts (#540) (#544)

* chore(release): 0.1.159

* Update nav.adoc

---------

Co-authored-by: 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 <>
* Update nav.adoc

* Add new version
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

@LandauRaz
Copy link
Collaborator Author

LandauRaz commented Jun 14, 2023

Also, the example on this page looks bad in dark mode:
image
but I didn't know what to do about it :/ WDYT?

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

JameStark
JameStark previously approved these changes Jun 16, 2023
Copy link
Contributor

@JameStark JameStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @LandauRaz)

@JameStark
Copy link
Contributor

Also, the example on this page looks bad in dark mode: image but I didn't know what to do about it :/ WDYT?

I agree.

Diagrams more broadly are being overhauled so I have made a note to add this to one of the diagrams that needs updating.

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-555/documentation/ .

@JameStark JameStark merged commit d03ec6a into dev Jun 16, 2023
@JameStark JameStark deleted the razl/starknet_state branch June 16, 2023 13:28
JameStark added a commit that referenced this pull request Jun 19, 2023
* rJames/hotfix menu caps (#545)

* chore(release): 0.1.158

* Update wording on AA Deploying accounts (#540) (#544)

* chore(release): 0.1.159

* Update nav.adoc

---------

Co-authored-by: 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 <>

* James/hotfix menu caps (#547)

* Update nav.adoc

* Add new version

* Update package.json (#552)

* fix: minor fixes in "Starknet state" (#555)

* Update starknet-state.adoc

---------
Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* Bump version

* Merge branch 'master' into dev

* Update starknet-state.adoc (#562)

* Merge branch 'master' into dev

* fix: minor fixes in "Class hash" (#556)

* minor fixes

Co-authored-by: JameStark <[email protected]>

* minor fixes

* Merge branch 'dev' into razl/syscalls0

Co-Authored-By: JameStark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants