Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix broken link, clarify sentence and request for clarification. #751

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Aug 21, 2023

Description of the Changes

Fix broken link, clarify sentence and request for clarification.

PR Preview URL

Class hash

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie requested a review from JameStark August 21, 2023 08:36
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-751/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-751/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-751/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-751/documentation/ .

@JameStark JameStark merged commit 139bb77 into dev Aug 22, 2023
@JameStark JameStark deleted the steve/minor_fix_class_hash branch August 22, 2023 08:11
JameStark added a commit that referenced this pull request Aug 22, 2023
…#751) (#759)

* Fix broken link, clarify sentence and request for clarification.

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/class-hash.adoc

* Update class-hash.adoc

---------

Co-authored-by: Steve Goodman <[email protected]>
JameStark added a commit that referenced this pull request Aug 22, 2023
* fix: Fix broken link, clarify sentence and request for clarification. (#751)

* Fix broken link, clarify sentence and request for clarification.

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/class-hash.adoc

* Update class-hash.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* Remove class hash for Cairo 0 (#760)

---------

Co-authored-by: Steve Goodman <[email protected]>
JameStark added a commit that referenced this pull request Aug 22, 2023
* fix: Fix broken link, clarify sentence and request for clarification. (#751)

* Fix broken link, clarify sentence and request for clarification.

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/class-hash.adoc

* Update class-hash.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* Remove class hash for Cairo 0 (#760)

* fix: Edits to inital sentence. (#741)

* Update index.adoc

* Tightening up some formatting.

* Update index.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

---------

Co-authored-by: Steve Goodman <[email protected]>
JameStark added a commit that referenced this pull request Aug 22, 2023
* fix: Fix broken link, clarify sentence and request for clarification. (#751)

* Fix broken link, clarify sentence and request for clarification.

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/class-hash.adoc

* Update class-hash.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* Remove class hash for Cairo 0 (#760)

* fix: Edits to inital sentence. (#741)

* Update index.adoc

* Tightening up some formatting.

* Update index.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* fix: remove cairo 0 examples (#729)

* Add read to Storage low level functions

* Remove Cairo 1.0 code examples

---------

Co-authored-by: Steve Goodman <[email protected]>
JameStark added a commit that referenced this pull request Aug 23, 2023
* fix: Fix broken link, clarify sentence and request for clarification. (#751)

* Fix broken link, clarify sentence and request for clarification.

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/class-hash.adoc

* Update class-hash.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* Remove class hash for Cairo 0 (#760)

* fix: Edits to inital sentence. (#741)

* Update index.adoc

* Tightening up some formatting.

* Update index.adoc

---------

Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

* fix: remove cairo 0 examples (#729)

* Add read to Storage low level functions

* Remove Cairo 1.0 code examples

* docs: add Juno v0.6.0 details (#765)

---------

Co-authored-by: Steve Goodman <[email protected]>
Co-authored-by: wojciechos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants