Skip to content

Commit

Permalink
Merge pull request #493 from 0xs34n/develop-to-beta
Browse files Browse the repository at this point in the history
Merge develop to beta
  • Loading branch information
penovicp authored Jan 13, 2023
2 parents af6b7ea + ef04862 commit 6242685
Show file tree
Hide file tree
Showing 58 changed files with 122,212 additions and 12,409 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/manual-devnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
services:
devnet:
image: shardlabs/starknet-devnet:0.4.0-seed0
image: shardlabs/starknet-devnet:0.4.2-seed0
ports:
- 5050:5050

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
services:
devnet:
image: shardlabs/starknet-devnet:0.4.0-seed0
image: shardlabs/starknet-devnet:0.4.2-seed0
ports:
- 5050:5050

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
services:
devnet:
image: shardlabs/starknet-devnet:0.4.0-seed0
image: shardlabs/starknet-devnet:0.4.2-seed0
ports:
- 5050:5050

Expand Down
37 changes: 37 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,43 @@

- uses BigInt and Faster Hashing

## [4.19.3](https://github.com/0xs34n/starknet.js/compare/v4.19.2...v4.19.3) (2023-01-12)

### Bug Fixes

- remove any type in simulateTransaction ([a94db18](https://github.com/0xs34n/starknet.js/commit/a94db1887c9fee676ac9b313190453abd5ea2554))
- update account.simulateTransaction return type ([3c3d397](https://github.com/0xs34n/starknet.js/commit/3c3d397a4fb1042c7358f70f50df0a4ce2893220))

## [4.19.2](https://github.com/0xs34n/starknet.js/compare/v4.19.1...v4.19.2) (2023-01-11)

### Bug Fixes

- repair and unify transaction retrieval error ([ea5e646](https://github.com/0xs34n/starknet.js/commit/ea5e64651bf47824b254ae73ed8aa88998a5be44))

## [4.19.1](https://github.com/0xs34n/starknet.js/compare/v4.19.0...v4.19.1) (2023-01-10)

### Bug Fixes

- describeIfDevnetSequencer ([4a088ad](https://github.com/0xs34n/starknet.js/commit/4a088ada404ef912976141d8fba1c66d791c273c))
- es6 ([e85ad45](https://github.com/0xs34n/starknet.js/commit/e85ad45c5565d93417b1a18e3663bd6c5e8861c1))
- estimate fee response bulk type ([78a1444](https://github.com/0xs34n/starknet.js/commit/78a14445c75b7ec259d6cfecd1cc17869b507dd8))
- tests ([5ab047f](https://github.com/0xs34n/starknet.js/commit/5ab047ff0b272057e70a29e909084d083db36a96))

# [4.19.0](https://github.com/0xs34n/starknet.js/compare/v4.18.0...v4.19.0) (2023-01-09)

### Bug Fixes

- merge develop into feat/add_estimate_fee_bulk ([88e76af](https://github.com/0xs34n/starknet.js/commit/88e76af68dd711b3f277c0a6d4f1935710aba4d7))
- update getEstimateFeeBulk function ([4b22c82](https://github.com/0xs34n/starknet.js/commit/4b22c8212f4586b37dc7c8ddfad77955e44b1b12))
- update types & add separate responseParser for estimateFeeBulk ([52110b2](https://github.com/0xs34n/starknet.js/commit/52110b289e3dfbbe449cf195709b2714f295a70d))

### Features

- add function estimateInvokeFeeBulk ([e716a18](https://github.com/0xs34n/starknet.js/commit/e716a1882f3ac37d17eae72a51cd3c4fc4649bcb))
- update estimateFeeBulk ([5ee94f7](https://github.com/0xs34n/starknet.js/commit/5ee94f78af681690905e1ead1de711e3a43c0774))
- update estimateFeeBulk function & doc ([ce20139](https://github.com/0xs34n/starknet.js/commit/ce201394142a19c4810a1e44cb3f601b815a11fe))
- update sequencer api ([a12f99e](https://github.com/0xs34n/starknet.js/commit/a12f99ea6e93fb5d44d4d07f7fa8cc2d997db91a))

# [4.18.0](https://github.com/0xs34n/starknet.js/compare/v4.17.1...v4.18.0) (2022-12-23)

### Bug Fixes
Expand Down
19 changes: 13 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# How to contribute

We love pull requests. And following this guidelines will make your pull request easier to merge.
We love pull requests. And following these guidelines will make your pull request easier to merge.

If you want to contribute but don’t know what to do, take a look at these two labels: [help wanted](https://github.com/seanjameshan/starknet.js/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22) and [good first issue](https://github.com/seanjameshan/starknet.js/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22).

Expand All @@ -14,7 +14,7 @@ _[Use GitHub interface](https://blog.sapegin.me/all/open-source-for-everyone/) f

## Development workflow

ALways start from `develop` branch and merge back to `develop` branch.
Start from the `develop` branch.

To build you changes run:

Expand All @@ -37,15 +37,22 @@ npm test --watch
**Don’t forget to add tests and update documentation for your changes.**
Documentation can be archived by using JSDoc.

**Please update npm lock file (`package-lock.json`) if you add or update dependencies.**
**Please update the npm lock file (`package-lock.json`) if you add or update dependencies.**

**For commit messages use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/), like so: `feat(scope): topic`**

### Pull request targets

For the most common pull requests such as bug fixes, feature additions, documentation changes, etc., target the `develop` branch.

For major changes that markedly transform the existing API or significantly alter the behavior of some functionality ensure that the corresponding commits contain appropriate `Conventional Commits` breaking change notations and as the pull request target select the `beta` branch.

## Other notes

- If you have commit access to repository and want to make big change or not sure about something, make a new branch and open pull request.
- If you have commit access to the repository and want to make a big change or are unsure about something, make a new branch and open a pull request.
- We’re using [Prettier](https://github.com/prettier/prettier) to format code, so don’t worry much about code formatting.
- Use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/), like so: `feat(scope): topic`
- Don’t commit generated files, like minified JavaScript.
- Don’t change version number and changelog.
- Don’t change the version number or changelog.

## Need help?

Expand Down
Loading

0 comments on commit 6242685

Please sign in to comment.