Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: validateChecksumAddress #1032

Merged
merged 1 commit into from
Mar 22, 2024
Merged

docs: validateChecksumAddress #1032

merged 1 commit into from
Mar 22, 2024

Conversation

ivpavici
Copy link
Collaborator

@ivpavici ivpavici commented Mar 22, 2024 •
edited
Loading

Motivation and Resolution

Closes #1031

RPC version (if applicable)

...

Usage related changes

  • Change 1.
  • ...

Development related changes

  • Change 1.
  • ...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@ivpavici ivpavici requested a review from tabaktoni March 22, 2024 12:16
tabaktoni
tabaktoni approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tabaktoni tabaktoni changed the base branch from develop to next-version March 22, 2024 13:42
@tabaktoni tabaktoni merged commit 60674d8 into next-version Mar 22, 2024
3 checks passed
@tabaktoni tabaktoni mentioned this pull request Mar 22, 2024
Merged
6 tasks
@penovicp penovicp deleted the ivpavici_1031 branch April 3, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabaktoni tabaktoni tabaktoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Braavos address fails the validateChecksumAddress
2 participants
@ivpavici @tabaktoni