-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare beta v7 #1328
Prepare beta v7 #1328
Conversation
@@ -2,7 +2,8 @@ import { RPC, RpcError } from '../../src'; | |||
|
|||
describe('Error utility tests', () => { | |||
test('RpcError', () => { | |||
const baseError: RPC.Errors.UNEXPECTED_ERROR = { | |||
// TODO: @penovicp types 0.8 exporta u top level sve 0.7 exporta po komponentama, neznan jeli treba minjat test i mod da ocukuje oba tipa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type export change shouldn't be an issue. The RPC error utility relies on the mappings set up in src/types/errors.ts
, so when the mapping is updated the utility should work regardless of how the underlying types are imported. It should work even without an update since the 0.7 errors are a subset of the 0.8 errors, the difference is that without it the new 0.8 errors wouldn't be recognised for type narrowing.
…rtial type export
…nfig & nodes, provider create
Motivation and Resolution
Starknet 0.13.4
RPC version (if applicable)
RPC 0.8
Usage related changes
Some test captured BreakingChanged:
Development related changes
When specVersion is not defined in constructor options, prefer usage of the
provider = await RpcProvider.create()
for safe spec version/ channel resolution based on the node. Else it fail back to config default rpc version that could be false based on node rpc.Testing
Checklist: