Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6 #893

Merged
merged 9 commits into from
Dec 14, 2023
Merged

V6 #893

merged 9 commits into from
Dec 14, 2023

Conversation

tabaktoni
Copy link
Collaborator

@tabaktoni tabaktoni commented Dec 12, 2023 •
edited
Loading

Motivation and Resolution

Provider / Provider Responses / Response parser
Fixed, Cleaned, Guard

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@tabaktoni tabaktoni changed the base branch from develop to beta December 12, 2023 07:58
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2023 •
edited
Loading

✅ Deploy Preview for starknetjs ready!

Name Link
🔨 Latest commit 76b6ab4
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/657812886f6ad5000880f948
😎 Deploy Preview https://deploy-preview-893--starknetjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tabaktoni tabaktoni changed the title V6/v3 transactions V6 Dec 12, 2023
penovicp
penovicp approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, lgtm

src/utils/responseParser/rpc.ts Outdated Show resolved Hide resolved
src/provider/rpc.ts Outdated Show resolved Hide resolved
src/types/api/rpcspec_0_6/components.ts Outdated Show resolved Hide resolved
src/utils/provider.ts Show resolved Hide resolved
src/utils/provider.ts Outdated Show resolved Hide resolved
@tabaktoni tabaktoni merged commit 877ad8c into beta Dec 14, 2023
1 check passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.0.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@penovicp penovicp deleted the v6/v3-transactions branch March 2, 2024 22:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penovicp penovicp penovicp approved these changes

@dhruvkelawala dhruvkelawala Awaiting requested review from dhruvkelawala

@janek26 janek26 Awaiting requested review from janek26

Assignees
No one assigned
Labels
released on @beta released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabaktoni @penovicp