fix: solve wrong response for account.verifyMessage

[PhilippeR26]

Motivation and Resolution

implement issue #858 about wrong answers of account.verifyMessage()
See issue for details.

Usage related changes

Breaking change : the result myAccount.verifyMessage(typedMessage, signature) is no more a boolean. It's now :

type SignatureVerifResult = {
  isVerificationProcessed: boolean;
  isSignatureValid?: boolean;
  error?: Error;
};

Example of usage :

const myAccount = new Account(provider, accountAddress, "0x0123"); // fake private key
const result = await myAccount.verifyMessage(typedMessage, signature);
if (result.isVerificationProcessed) {
    console.log("Result (boolean) =", result.isSignatureValid);
} else {
    console.log("verification failed :", result.error);
}

Development related changes

There is no standard in Starknet for Cairo IsValidSignature account function response.

• OpenZeppelin 0.5.0 (cairo 0) and 0.8.0 (Cairo 2.3.1) are responding 0 in case of wrong signature.
• ArgentX 0.3.0 (Cairo 2.0.0) is reverting with a specific message.
• Same thing for Braavos (Cairo 0), with a different message.

The code is adapted in accordance.

Checklist:

• Performed a self-review of the code
• Rebased to the last commit of the target branch (or merged it into my branch)
• Linked the issues which this PR resolves
• Documented the changes in code (API docs will be generated automatically)
• Updated the tests
• All tests are passing (in beta 3)

[tabaktoni]

Looking good for now,
we can rethink-update support for C. Acc later on.

[github-actions]

🎉 This PR is included in version 6.0.0-beta.13 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀