Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PartialEq for 2,3,4-tuples #3556

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

milancermak
Copy link
Contributor

@milancermak milancermak commented Jun 30, 2023

PR adds support for PartialEq for tuples of 2, 3 and 4 elements.

There are other impls for tuples of sizes up to 4, but PartialEq is missing.


This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @milancermak)


corelib/src/traits.cairo line 242 at r1 (raw file):

        let (lhs0, lhs1) = lhs;
        let (rhs0, rhs1) = rhs;
        (lhs0 == rhs0) && (lhs1 == rhs1)

also the others.

Suggestion:

        lhs0 == rhs0 && lhs1 == rhs1

Copy link
Contributor Author

@milancermak milancermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/traits.cairo line 242 at r1 (raw file):

Previously, orizi wrote…

also the others.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @milancermak)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @milancermak)

a discussion (no related file):
@gilbens-starkware for 2nd eye.


Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @milancermak)

@orizi orizi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into starkware-libs:main with commit ac22d98 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants