-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed StorageValue into Store. #3677
Conversation
912739e
to
701d610
Compare
701d610
to
476b2de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 27 files at r1.
Reviewable status: 13 of 27 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/test_data/account.sierra
line 288 at r1 (raw file):
libfunc store_temp<NonZero<EcPoint>> = store_temp<NonZero<EcPoint>>; libfunc unwrap_non_zero<EcPoint> = unwrap_non_zero<EcPoint>; libfunc dup<felt252> = dup<felt252>;
I don't understand why it affects the Sierra code.
commit-id:90b4d99b
476b2de
to
54d6701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 27 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-starknet/test_data/account.sierra
line 288 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
I don't understand why it affects the Sierra code.
it doesn't - accidental commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 27 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
This change is