Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed StorageValue into Store. #3677

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jul 13, 2023

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware July 13, 2023 13:12
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/90b4d99b branch 2 times, most recently from 912739e to 701d610 Compare July 13, 2023 13:20
@orizi orizi changed the base branch from pr/orizi/orizi/storage-access-updates/e2611531 to main July 13, 2023 13:30
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/90b4d99b branch from 701d610 to 476b2de Compare July 13, 2023 13:30
@orizi orizi enabled auto-merge July 13, 2023 13:31
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 27 files at r1.
Reviewable status: 13 of 27 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-starknet/test_data/account.sierra line 288 at r1 (raw file):

libfunc store_temp<NonZero<EcPoint>> = store_temp<NonZero<EcPoint>>;
libfunc unwrap_non_zero<EcPoint> = unwrap_non_zero<EcPoint>;
libfunc dup<felt252> = dup<felt252>;

I don't understand why it affects the Sierra code.

@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/90b4d99b branch from 476b2de to 54d6701 Compare July 13, 2023 13:41
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 13 of 27 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-starknet/test_data/account.sierra line 288 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

I don't understand why it affects the Sierra code.

it doesn't - accidental commit.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 27 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 1edcc13 Jul 13, 2023
@orizi orizi deleted the pr/orizi/orizi/storage-access-updates/90b4d99b branch July 16, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants