Avoid copying green nodes.

[ilyalesokhin-starkware]

This change is 

[orizi]

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-parser/src/parser.rs line 1198 at r1 (raw file):

            kind: SyntaxKind::ExprPath,
            details: GreenNodeDetails::Node { children: children0, .. },
        } = &*self.db.lookup_intern_green(expr.0)

consider
(also everywhere)

Suggestion:

self.db.lookup_intern_green(expr.0).as_ref()

[ilyalesokhin-starkware]

Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-parser/src/parser.rs line 1198 at r1 (raw file):

Previously, orizi wrote…

consider
(also everywhere)

Got

Code snippet:

1198 |         } = self.db.lookup_intern_green(expr.0).as_ref()
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)