Allocate arguments before return values. #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orizi
requested changes
Oct 15, 2023
There was a problem hiding this comment.
Reviewed 59 of 60 files at r1, all commit messages.
Reviewable status: 59 of 60 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-starknet/test_data/invalid_consts.json line 2 at r1 (raw file):
{ "sierra_program": [
is this part of this PR?
ilyalesokhin-starkware
force-pushed
the
ilya/alloc_args
branch
from
339b172 to
3e1c082
Compare
There was a problem hiding this comment.
Reviewable status: 59 of 60 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/test_data/invalid_consts.json line 2 at r1 (raw file):
Previously, orizi wrote…
is this part of this PR?
Removed.
orizi
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is