Raise diagnostic on impl inference cycle.

[gilbens-starkware]

This change is 

[orizi]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

crates/cairo-lang-semantic/src/items/imp.rs line 734 at r1 (raw file):

        }
        let Ok(concrete_trait_id) = uninferred_impl.concrete_trait(db) else {
            println!("Failed to get concrete trait for {:?}", uninferred_impl.debug(db.elongate()));

remove.

[gilbens-starkware]

Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-semantic/src/items/imp.rs line 734 at r1 (raw file):

Previously, orizi wrote…

remove.

Done.

[orizi]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

[gilbens-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)