Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant gas assertions. #4464

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 23, 2023

This change is Reviewable

@orizi orizi enabled auto-merge November 23, 2023 15:09
@orizi orizi force-pushed the orizi/disable-cost-comparison branch 2 times, most recently from 6fdd966 to 35aeade Compare November 23, 2023 15:11
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @liorgold2)

@orizi orizi changed the title Bumped version to 2.4.0-rc4. (#4463) Remove redundant gas assertions. Nov 23, 2023
@orizi orizi linked an issue Nov 23, 2023 that may be closed by this pull request
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@orizi orizi force-pushed the orizi/disable-cost-comparison branch from 35aeade to a8934c7 Compare November 23, 2023 15:20
@orizi orizi added this pull request to the merge queue Nov 23, 2023
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @liorgold2)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @liorgold2)

Merged via the queue into dev-v2.4.0 with commit 46b323d Nov 23, 2023
38 checks passed
Copy link
Collaborator

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@orizi orizi deleted the orizi/disable-cost-comparison branch November 26, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Difference in (StatementIdx(97456), Bitwise): Some(2) != Some(0).
3 participants