ImplTypeDefId/ImplTypeId distinction

[yuvalsw]

This change is 

[orizi]

Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)

---

crates/cairo-lang-semantic/src/types.rs line 357 at r1 (raw file):

        if let crate::items::imp::ImplId::Concrete(concrete_impl) = impl_id {
            let impl_def_id = concrete_impl.impl_def_id(db);
            assert_eq!(ty.trait_id(db.upcast()), db.impl_def_trait(impl_def_id).unwrap());

Suggestion:

            assert_eq!(Some(ty.trait_id(db.upcast())), db.impl_def_trait(impl_def_id));

[yuvalsw]

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-semantic/src/types.rs line 357 at r1 (raw file):

        if let crate::items::imp::ImplId::Concrete(concrete_impl) = impl_id {
            let impl_def_id = concrete_impl.impl_def_id(db);
            assert_eq!(ty.trait_id(db.upcast()), db.impl_def_trait(impl_def_id).unwrap());

Done.

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)