Replace arc_unwrap_or_clone with now stable Arc::unwrap_or_clone
#5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Arc::unwrap_or_clone` function was stabilized in Rust 1.76
yuvalsw
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput)
crates/cairo-lang-test-plugin/src/lib.rs line 31 at r1 (raw file):
use cairo_lang_utils::unordered_hash_map::UnorderedHashMap; use itertools::{chain, Itertools}; pub use plugin::TestPlugin;
Not that it's important, but why did this move?
mkaput
commented
Mar 12, 2024
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yuvalsw)
crates/cairo-lang-test-plugin/src/lib.rs line 31 at r1 (raw file):
Previously, yuvalsw wrote…
Not that it's important, but why did this move?
RustRover's imports organizer did this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Arc::unwrap_or_clonefunction was stabilized in Rust 1.76This change is